Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 82.75% 82.21% -0.55%
==========================================
Files 23 23
Lines 928 911 -17
==========================================
- Hits 768 749 -19
- Misses 160 162 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
This seems good! I agree with both of your "Why"s. I am not familiar with |
Contributor
Author
|
Reasons for:
Possible doubts:
An alternative could be:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
periodis a bit disingenuousExecution of job "readback_position (trigger: interval[0:00:00.010000], next run at: 2024-10-29 15:13:39 GMT)" skipped: maximum number of running instances reached (1)Possibly useful options not used:
Uncertain: